Skip to content

chore(ups): remove no responders #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(ups): remove no responders #2863

wants to merge 1 commit into from
+31 −145

Conversation

NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Sep 4, 2025 •
edited
Loading

Fixes RVT-5116
Fixes RVT-5117

@NathanFlurry NathanFlurry mentioned this pull request Sep 4, 2025
Closed
@linear Linear
Copy link

linear bot commented Sep 4, 2025

RVT-5116 Remove no responders

@NathanFlurry NathanFlurry mentioned this pull request Sep 4, 2025
Closed
@vercel Vercel
Copy link

vercel bot commented Sep 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-site Ready Ready Preview Comment Sep 8, 2025 5:41am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rivet-studio Ignored Ignored Preview Sep 8, 2025 5:41am

This was referenced Sep 4, 2025
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Sep 4, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude Claude
Copy link

claude bot commented Sep 4, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 4, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2863

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2863

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2863

commit: 0678b46

graphite-app[bot]
graphite-app bot reviewed Sep 4, 2025
View reviewed changes
packages/common/universalpubsub/src/driver/postgres/mod.rs
Comment on lines +305 to +306
// Normal path: use database for request/response
tracing::debug!(%subject, "using database path for request");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Issue: Removing Listener Check Causes Resource Waste

The removal of the listener check (lines 326-364) introduces a significant performance and resource problem. Without this check, the system will:

  1. Create unnecessary database connections
  2. Wait for the full timeout period for every request to subjects with no listeners
  3. Waste resources instead of failing fast

While consolidating error types is reasonable, the optimization logic should be preserved. Consider modifying the existing check to return RequestTimeout instead of NoResponders when no listeners are found:

if !has_listeners {
    tracing::warn!(%subject, "no listeners found for subject");
    return Err(errors::Ups::RequestTimeout.build().into());
}

This maintains the performance optimization while achieving the goal of error type consolidation.

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

@linear Linear
Copy link

linear bot commented Sep 5, 2025

RVT-5117 Update runner to connect tunnel first

This was referenced Sep 5, 2025
Closed
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the 09-04-chore_runner_disable_default_logs branch from 95f5243 to 8b94417 Compare September 8, 2025 05:12
@NathanFlurry NathanFlurry force-pushed the 09-04-chore_ups_remove_no_responders branch from f957fbb to 0678b46 Compare September 8, 2025 05:12
@claude Claude
Copy link

claude bot commented Sep 8, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Sep 8, 2025
Merged
@claude Claude
Copy link

claude bot commented Sep 8, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@graphite-app graphite-app bot changed the base branch from 09-04-chore_runner_disable_default_logs to graphite-base/2863 September 8, 2025 07:14
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Sep 8, 2025 •
edited
Loading

Merge activity

  • Sep 8, 9:50 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Sep 8, 9:50 PM UTC: CI is running for this pull request on a draft pull request (#2887) due to your merge queue CI optimization settings.
  • Sep 8, 9:51 PM UTC: Merged by the Graphite merge queue via draft PR: #2887.

graphite-app bot pushed a commit that referenced this pull request Sep 8, 2025
@NathanFlurry
chore(ups): remove no responders (#2863)
6b4c00b 
Fixes RVT-5116
Fixes RVT-5117
@graphite-app graphite-app bot closed this Sep 8, 2025
@graphite-app graphite-app bot deleted the 09-04-chore_ups_remove_no_responders branch September 8, 2025 21:51
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
Merged
This was referenced Sep 9, 2025
Merged
Closed
Closed
Merged
Merged
Merged
This was referenced Sep 12, 2025
Closed
Open
Open
Draft
Draft
Draft
Merged
This was referenced Sep 13, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@NathanFlurry NathanFlurry mentioned this pull request Sep 14, 2025
Merged
@jog1t jog1t mentioned this pull request Sep 15, 2025
Closed
This was referenced Sep 15, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato